rusackas commented on PR #37794: URL: https://github.com/apache/superset/pull/37794#issuecomment-5040133911
Thanks for adding the alignment control, that's exactly what I was hoping for. But this diff does a lot more than that. Codeant's open threads on this PR look right to me: `BigNumberWithTrendline/transformProps.ts` drops the `queriesData[1]` raw-aggregation path entirely (around line 96), the echarts config no longer builds `xAxis`/`yAxis`/`grid` so the show-axis and min/max-label controls become no-ops, and `forceTimestampFormatting` is gone from the formatter selection. `BigNumberViz.tsx` also stops wiring `onContextMenu` into the rendered header, so drill-to-detail no longer fires on the big number itself. Can we scope this back down to just the alignment control and leave the rest of the trendline/total behavior alone? Happy to take another look once those threads are addressed, or let me know if you object/approve of me getting involved in pushing some commits here... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
