rusackas commented on PR #41184: URL: https://github.com/apache/superset/pull/41184#issuecomment-5041521649
Thanks for digging in, @aminghadersohi. Good lead... though it turned out not to be the last-row logic at all. `splitGroupingSetsResult` attributes each row to a rollup level via the `GROUPING()` marker columns, and the old test fixtures feed rows with no markers, so every row got filtered out and the table rendered empty. Fixed by treating marker-less results as leaf-level data (blank totals cells beat a blank chart), with a unit test to pin it down, and merged current `master` while I was in there. CI's green again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
