rusackas commented on PR #38584: URL: https://github.com/apache/superset/pull/38584#issuecomment-5041591741
Thanks @mkramer5454, glad to see this rebased and the core fix still looks solid. One thing before this can merge, though. `package.json` and `package-lock.json` showed up again at the repo root, pulling in `oxlint`. Looks like those got dropped once already but crept back in through a master merge. Nothing here should be touching the root of the JS workspace, so those need to come back out. EnxDev's should-fix on `SaveModal.test.tsx` (the fetchMock routes leaking between tests) is still open too, if you don't mind cleaning that up while you're in there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
