willbarrett commented on a change in pull request #8457: [fix] Improve csv
upload functionality
URL:
https://github.com/apache/incubator-superset/pull/8457#discussion_r339706989
##########
File path: superset/views/database/views.py
##########
@@ -102,10 +102,10 @@ def form_post(self, form):
if not self.is_schema_allowed(database, schema_name):
message = _(
- 'Database "{0}" Schema "{1}" is not allowed for csv uploads. '
- "Please contact Superset Admin".format(
- database.database_name, schema_name
- )
+ 'Database "%(database_name)s" schema "%(schema_name)s" '
+ "is not allowed for csv uploads. Please contact Superset
Admin",
Review comment:
I think we're missing a possessive - should this be "Please contact your
Superset admin"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
