EmmanuelCbd commented on PR #31981:
URL: https://github.com/apache/superset/pull/31981#issuecomment-5048194816
Hi @rusackas, thanks for all the detailed feedback and for keeping this
alive.
Quick update: the colleague who did the original Spanish translation work
has left the company, so I went ahead and addressed the remaining issues myself
(with some help from Claude AI), and I'd like the community's eyes on the
wording before we merge.
What I fixed, on top of your rebase:
- **The two runtime bugs you flagged**: `%(name)s.pdf` was mistranslated as
`%(name)s.csv`, and `Applied filters (%s)` was using `%d` (would crash on
non-integer values). Both fixed.
- **tú vs usted**: went with `tú` throughout, matching master's dominant
convention (~30 `Selecciona`-style forms vs a couple of `usted` outliers). Also
aligned `tablero`→`panel de control` and `agregar`→`añadir` to match existing
terminology.
- **Dropped placeholders**: found ~60 more entries where `%s`/`%(name)s` had
been dropped and replaced with a fixed word (e.g. `Edit %s` → `Editar
usuario`). Turns out these are shared templates called from multiple places
with a runtime value — e.g. `t('Edit %s', datasetLabelLower())` is called for
datasets, charts, semantic views, etc. So the hardcoded translation was only
ever correct for one of those cases. I checked each one against its actual call
site in `superset-frontend/src`/`superset/` and restored the placeholder with a
translation built around it.
`pybabel compile`'s format-string check went from 65 errors down to 3, and
those 3 remaining (`% calculation`, `% of parent`, `% of total`) are checker
false positives — the literal `% c`/`% o` substring gets misread as a format
directive even though no argument is ever substituted there.
None of this is native-speaker-reviewed — I don't speak Spanish myself, so
please treat the wording as a proposal rather than a final answer. Happy to
adjust based on feedback, or if anyone wants to just push corrections directly,
that works too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
