rusackas commented on PR #42315: URL: https://github.com/apache/superset/pull/42315#issuecomment-5052679330
Reopened and rebased now that #42317 fixed the crash on `master`. This version keeps the pieces that PR didn't have: the locale logic broken out into `echartsLocale.ts` with its own test suite, and the `LegacyGridContainLabel` registration so `grid.containLabel` keeps working under echarts 6 instead of silently clipping axis labels. Since `LegacyGridContainLabel` only exists in echarts 6.x, this is stacked on #42321 (the re-bump) — the base is set to that branch so CI runs against 6.1.0, and GitHub will retarget to `master` when it merges. Both locale test suites (this PR's `echartsLocale.test.ts` and the one #42317 added) pass against 6.1.0 locally: 33 tests across the two files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
