prathamesh04 opened a new pull request, #42339:
URL: https://github.com/apache/superset/pull/42339
## Summary
Closes #40766
was the only export command that did not extend . It was a standalone class
with all methods and a custom classmethod interface, requiring special-case
handling in and callers.
This refactoring makes extend , bringing it in line with the rest of the
export command architecture.
## Changes
- ****: now extends with and . Overrides to handle tag-specific export
logic. accepts both / (for consistency with parent) and / (for the
tag-specific interface). The static method is preserved for backward
compatibility.
- ****: Updated to use instead of . Removed the FIXME comment about
aligning the tags export command.
- ****: Updated to use instead of .
- ****: Updated to use instead of .
- ****: Updated mock to match new interface.
## Testing
### Unit Tests
```bash
cd superset-frontend && npm run test -- --testPathPattern=export_test
```
### Backend Tests
```bash
pytest tests/unit_tests/commands/export_test.py -v
```
### Manual Testing
1. Enable `TAGGING_SYSTEM` feature flag in `superset_config.py`
2. Create a dashboard with tags and a chart with tags
3. Export dashboards via API: `GET /api/v1/dashboard/export/?q=(ids:)`
4. Verify the exported zip contains `tags.yaml` with merged tags from both
dashboards and charts
5. Export charts individually and verify tags are included
6. Run the full asset export and verify all files are correct
### Regression Check
- Verify that importing the exported bundle recreates all tags correctly
- Verify that tag deduplication works (same tag name on dashboard and chart
appears once)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
