mistercrunch edited a comment on issue #8463: Make pydruid truly optional URL: https://github.com/apache/incubator-superset/pull/8463#issuecomment-547208073 I'm generally against big `try:` blocks. Try block should target small number of lines and catch targeted errors as much as possible. Also I'm not sure if we should have conditional method definitions at all ever. I think this could be related to @craig-rueda 's work that moves the `appbuilder.add_view` in an app init method somewhere. Having logic around `init_app` as to which views to register would make sense.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
