rusackas commented on PR #35962: URL: https://github.com/apache/superset/pull/35962#issuecomment-5062747648
Anthony, just checking back in here. Still curious whether there's a concrete repro on current `master` where columns actually get dropped for an empty result set. From what I traced, the per-column loop above already builds a zero-length array for every column name, so `pa_data` and `column_names` are always the same length and the new `if not pa_data and column_names` branch never fires. If you can't find a repro, I'd rather land just the test as a regression guard and drop the code hunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
