bito-code-review[bot] commented on code in PR #42146:
URL: https://github.com/apache/superset/pull/42146#discussion_r3641188689
##########
superset-frontend/src/features/databases/DatabaseModal/styles.ts:
##########
@@ -158,7 +158,7 @@ export const antDErrorAlertStyles = (theme: SupersetTheme)
=> css`
export const antdWarningAlertStyles = (theme: SupersetTheme) => css`
margin: ${theme.sizeUnit * 4}px 0;
- .ant-alert-message {
+ .ant-alert-title {
margin: 0;
}
`;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Inconsistent antd class name</b></div>
<div id="fix">
The CSS class change `.ant-alert-message` → `.ant-alert-title` is correct
(antd v6 renamed this class). However,
`cypress-base/cypress/support/directories.ts:106` still references
`.ant-alert-message` for `databasesPage.modal.alertMessage`. Cypress locators
targeting this selector will fail to find alert titles. Update the selector to
`.ant-alert-title` to maintain consistency with the styled component.
</div>
</div>
<small><i>Code Review Run #995427</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
