bito-code-review[bot] commented on PR #42399:
URL: https://github.com/apache/superset/pull/42399#issuecomment-5074210070
<!-- Bito Reply -->
The code change in `superset/commands/importers/v1/utils.py` addresses the
security concern by removing the logging of the full `config` object, which
could contain sensitive information. Instead, it now logs only the sorted list
of field names present in the configuration. This change effectively mitigates
the risk of clear-text logging of sensitive data while still providing useful
debugging information.
**superset/commands/importers/v1/utils.py**
```
# Log field names only; full values can be huge (e.g. inline
# example data) and drown out the validation error above.
logger.debug(
"Config fields present in %s: %s", file_name,
sorted(config)
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
