villebro commented on PR #38280:
URL: https://github.com/apache/superset/pull/38280#issuecomment-5074533624

   Hi @ivkhokhlachev , thanks for the detailed write-up. I agree with 
@joe-clickhouse that setting it by default to 1 is the correct way to address 
this, as Superset heavily depends on this assumption. I think the best solution 
would be to default `connect_args` to `{"settings": 
{"prefer_column_name_to_alias": 1}}`, and then merge any additional 
`connect_args` the user defines into the final dict (some type of deep merge 
that would allow adding new `settings` but retaining the default seems best).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to