codeant-ai-for-open-source[bot] commented on code in PR #41921:
URL: https://github.com/apache/superset/pull/41921#discussion_r3649030594
##########
superset/mcp_service/middleware.py:
##########
@@ -132,6 +138,29 @@ def _sanitize_error_for_logging(error: Exception) -> str:
return error_str
+def _invoke_error_hook(error: Exception, hook_context: dict[str, Any]) -> None:
+ """Invoke the operator-configured ``MCP_ERROR_HOOK``, if any.
+
+ Kept vendor-neutral (no ``sentry_sdk`` import here) so the OSS repo has
+ no hard dependency on any particular error tracker — operators wire
+ their own hook (e.g. calling ``sentry_sdk.capture_exception``) via
+ ``MCP_ERROR_HOOK`` in ``superset_config.py``. Hook failures are logged
+ and swallowed; they must never affect the MCP response.
+ """
+ try:
+ from superset.mcp_service.flask_singleton import get_flask_app
+
+ hook = get_flask_app().config.get("MCP_ERROR_HOOK")
+ except Exception: # noqa: BLE001
+ return
+ if hook is None:
+ return
+ try:
+ hook(error, hook_context)
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag synchronous MCP error hook execution on the asyncio event loop
as a bug; this is an intentional contract, and hooks are expected to remain
fast or hand off I/O to their own background transport.
**Applied to:**
- `superset/mcp_service/middleware.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
