rusackas opened a new pull request, #42406:
URL: https://github.com/apache/superset/pull/42406

   ### SUMMARY
   Adds an E2E regression test for the Drill to Detail modal's results table.
   
   The drill pane measures its available height with a resize detector and 
hands it to a virtualized table, wired through Emotion selectors on antd's 
internal modal classes. When the antd v6 upgrade (#41636) renamed 
`.ant-modal-content` to `.ant-modal-container`, that height chain silently 
broke: the table flashed its rows, then collapsed to an empty body with only 
the header and pagination visible. #42146 fixed the selectors; nothing pins the 
behavior, since class-name contract tests can't see layout and only a real 
browser can.
   
   The spec builds its own single-chart dashboard (per the #41433 helper 
pattern), opens Drill to detail from the chart context menu, and asserts the 
virtualized body holds a real height across two consecutive reads — a single 
read could pass during the pre-collapse flash — and that actual sample rows are 
visible.
   
   Verified red against a pre-#42146 bundle: the height assertion fails with 
the body settled at 1px, which is exactly the regression's signature.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A (test only)
   
   ### TESTING INSTRUCTIONS
   ```bash
   cd superset-frontend
   npx playwright test tests/dashboard/drill-to-detail.spec.ts
   ```
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to