villebro commented on a change in pull request #8464: [SIP-15] Fixing datetime
conversion and SQL literal
URL:
https://github.com/apache/incubator-superset/pull/8464#discussion_r340279568
##########
File path: superset/db_engine_specs/impala.py
##########
@@ -43,11 +43,13 @@ def epoch_to_dttm(cls) -> str:
return "from_unixtime({col})"
@classmethod
- def convert_dttm(cls, target_type: str, dttm: datetime) -> str:
+ def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]:
tt = target_type.upper()
if tt == "DATE":
- return "'{}'".format(dttm.strftime("%Y-%m-%d"))
- return "'{}'".format(dttm.strftime("%Y-%m-%d %H:%M:%S"))
+ return f"CAST('{dttm.date().isoformat()}' AS DATE)"
+ elif tt == "TIMESTAMP":
+ return f"""CAST('{dttm.isoformat(sep=" ", timespec="seconds")}' AS
TIMESTAMP)""" # pylint: disable=line-too-long
Review comment:
It seems Impala is ok with the "T" separator, and should support nanosecond
precision, i.e. should be ok with `dttm.isoformat()`:
https://impala.apache.org/docs/build/html/topics/impala_timestamp.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
