john-bodley commented on a change in pull request #8464: [SIP-15] Fixing
datetime conversion and SQL literal
URL:
https://github.com/apache/incubator-superset/pull/8464#discussion_r340336470
##########
File path: superset/db_engine_specs/oracle.py
##########
@@ -39,7 +40,10 @@ class OracleEngineSpec(PostgresBaseEngineSpec):
}
@classmethod
- def convert_dttm(cls, target_type: str, dttm: datetime) -> str:
- return ("""TO_TIMESTAMP('{}',
'YYYY-MM-DD"T"HH24:MI:SS.ff6')""").format(
- dttm.isoformat()
- )
+ def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]:
+ tt = target_type.upper()
+ if tt == "DATE":
+ return f"TO_DATE('{dttm.date().isoformat()}', 'YYYY-MM-DD')"
+ if tt == "TIMESTAMP":
+ return f"""TO_TIMESTAMP('{dttm.isoformat(sep=" ",
timespec="microseconds")}', 'YYYY-MM-DD HH24:MI:SS.ff6')""" # pylint:
disable=line-too-long
Review comment:
@villbro I’ll add the `T`. The default timespec is `auto` which may or may
not include microseconds depending on how the `datetime` object was
constructed. I thought it would be best to be explicit here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
