rusackas commented on code in PR #42400:
URL: https://github.com/apache/superset/pull/42400#discussion_r3651865187
##########
superset/semantic_layers/api.py:
##########
@@ -614,8 +614,15 @@ def configuration_schema(self) -> FlaskResponse:
warning: str | None = None
try:
schema = cls.get_configuration_schema(parsed_config)
- except Exception as ex: # pylint: disable=broad-except
- warning = str(ex)
+ except Exception: # pylint: disable=broad-except
Review Comment:
`logger.exception()` already captures the full traceback server-side (it's
`exc_info=True` under the hood), so we're not losing context there. Keeping the
raw exception text out of the API response is the actual point of this change,
don't want to leak internal details to whoever's looking at the form.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
