bito-code-review[bot] commented on PR #42431:
URL: https://github.com/apache/superset/pull/42431#issuecomment-5082367018
<!-- Bito Reply -->
The flagged issue is correct. A type assertion like `(error as Error)` does
not perform runtime validation, so if the caught value is not an `Error`
object, `error.message` will be undefined. To resolve this, you should
normalize the error before accessing its properties.
Here is a concise fix:
```typescript
} catch (error) {
const message = error instanceof Error ? error.message : String(error);
dispatch(setQueryError(message));
} finally {
```
I have checked the PR comments, and there are no other pending review
comments to address. Would you like me to perform any other checks?
**superset-frontend/src/database/actions.ts**
```
} catch (error) {
const message = error instanceof Error ? error.message : String(error);
dispatch(setQueryError(message));
} finally {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
