prathamesh04 opened a new pull request, #42438:
URL: https://github.com/apache/superset/pull/42438
## Summary
Closes #42433
The endpoint was protected by , which caused a **302 redirect to ** for
unauthenticated requests. This silently broke i18n for all embedded dashboards
using non-English locales.
Embedded dashboards use a bare without the guest-token header, so the async
language pack fetch in was always blocked. The bootstrap-injected pack path ()
also depends on the JSON catalogs existing on disk — the official Docker image
ships only files, so when the pack is the fallback fetch was the only path to
load translations, and it was broken.
## Root Cause
1. ** blocks embedded guest users**: The language pack endpoint requires
authenticated access. The embedded SPA's bare has no guest-token header → 302
to
2. **Official image lacks compiled catalogs**: files are not shipped, so
returns , making the bootstrap-injected pack empty/null
3. **The async fallback was the only viable path** but was blocked by
## Fix
- Remove from the endpoint (translation data is non-sensitive)
- Add tests verifying the endpoint is accessible without authentication and
rejects invalid language codes
## Testing Instructions
1. Run the new unit tests:
2. Verify all existing tests still pass:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
