Abdulrehman-PIAIC80387 commented on issue #38012: URL: https://github.com/apache/superset/issues/38012#issuecomment-5088645793
@rusackas No strong reason I can find — looks like an oversight. `RefreshDatasetCommand` runs after the row is already committed, so hard-failing on a Jinja parse error just misleads the user. Best-effort is the right call. PR incoming with a narrow catch of `SupersetGenericDBErrorException` only — security exceptions and unexpected errors still propagate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
