codeant-ai-for-open-source[bot] commented on code in PR #37516:
URL: https://github.com/apache/superset/pull/37516#discussion_r3656236679
##########
superset/commands/explore/get.py:
##########
@@ -125,16 +126,17 @@ def run(self) -> Optional[dict[str, Any]]: # noqa: C901
datasource_name = datasource.name
if slc:
security_manager.raise_for_access(chart=slc)
+ elif isinstance(datasource, Query):
+ datasource.raise_for_explore_access()
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag Query access checks that call raise_for_explore_access(),
because it delegates internally to security_manager.raise_for_access().
**Applied to:**
- `superset/commands/explore/get.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
