rusackas commented on code in PR #37141:
URL: https://github.com/apache/superset/pull/37141#discussion_r3656654737
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -739,6 +776,36 @@ const DashboardBuilder = () => {
`}
/>
)}
+ {/* Mobile filters drawer */}
+ {!isNotMobile && nativeFiltersEnabled && (
+ <Drawer
+ title={t('Filters')}
+ placement="left"
+ onClose={() => setMobileFiltersOpen(false)}
+ open={mobileFiltersOpen}
+ width="85vw"
+ styles={{
+ body: {
+ padding: 0,
+ display: 'flex',
+ flexDirection: 'column',
+ },
+ }}
+ >
+ <FilterBar
+ orientation={FilterBarOrientation.Vertical}
+ verticalConfig={{
+ filtersOpen: true,
+ toggleFiltersBar: () => {},
Review Comment:
Not a bug: mobileMode hides both places that call toggleFiltersBar (the
Header close button and CollapsedBar toggle are gated on !mobileMode). The
drawers own onClose, wired to setMobileFiltersOpen(false) in DashboardBuilder,
is what closes it on mobile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
