EnxDev commented on code in PR #42472:
URL: https://github.com/apache/superset/pull/42472#discussion_r3658318462
##########
superset/subjects/api.py:
##########
@@ -19,7 +19,7 @@
from flask_appbuilder.models.sqla.interface import SQLAInterface
from superset.constants import RouteMethod
-from superset.subjects.filters import SubjectAllTextFilter
+from superset.subjects.filters import SubjectAllTextFilter, SubjectListFilter
Review Comment:
SubjectAllTextFilter is still referenced — search_filters = {"label":
[SubjectAllTextFilter]} at superset/subjects/api.py:124. The symbol this PR
actually added to the import is SubjectListFilter, wired into base_filters at
line 55. Both are used, and ruff --select F401 reports no unused import here,
so there's nothing to remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
