mikebridge commented on PR #42469: URL: https://github.com/apache/superset/pull/42469#issuecomment-5094526822
Review follow-through (55644945f3): - **Taken — finding 2**: `restore_version_endpoint` now passes `entity_id=result.entity.id` to `set_version_etag_by_uuid`, matching the sibling endpoints. - **Taken — finding 3**: `_restore_dashboard_membership` reuses `shadow_rows_valid_at` instead of hand-rolling the validity-window predicate, and the Continuum DELETE op-code is now a single shared `OPERATION_DELETE` constant (baseline/shadow.py) used by the restore guard and every validity predicate. - **Taken — finding 5**: `capture_enabled()` documents the operational constraint (config read at call time vs listeners attached at `init_versioning()`; runtime flips require a restart). - **Ticketed — finding 1**: sc-115325 (pre-existing `position_json` / membership divergence, product-wide). - **Ticketed — finding 4**: sc-115326 (non-SQLAlchemy exceptions bypass the 422 mapping; unreachable until a 4th entity is wired). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
