bxsx commented on code in PR #42494:
URL: https://github.com/apache/superset/pull/42494#discussion_r3662002955
##########
superset/reports/schemas.py:
##########
@@ -269,6 +273,10 @@ class ReportSchedulePostSchema(Schema):
dump_default=None,
)
force_screenshot = fields.Boolean(dump_default=False)
+ include_cta = fields.Boolean(
+ dump_default=True,
+ metadata={"description": include_cta_description},
+ )
Review Comment:
Good catch — the UI always coerces (missing/null → true), but an API client
doing a naive GET→PUT round-trip of a legacy NULL row would hit a validation
error. Fixed in 9c396f7: both schemas now accept an explicit null
(allow_none=True), which is coherent with the storage semantics (NULL is
treated as true at execution time), and the schema test now covers the null
round-trip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
