graceguo-supercat commented on a change in pull request #8404:
[WIP][feature]Dashboard filter scope selector modal
URL:
https://github.com/apache/incubator-superset/pull/8404#discussion_r340461939
##########
File path: superset/assets/src/dashboard/reducers/dashboardFilters.js
##########
@@ -32,11 +31,13 @@ import { buildActiveFilters } from
'../util/activeDashboardFilters';
export const dashboardFilter = {
chartId: 0,
componentId: '',
+ filterName: '',
Review comment:
i prefer to initialize primitive types with primitive value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
