rusackas commented on PR #39857: URL: https://github.com/apache/superset/pull/39857#issuecomment-5099432749
test-sqlite is red on this branch — AnnotationLayerImportError/ChartImportError are coming straight out of the new annotation import path (SQLite datetime type errors), not a flake. Needs to be green before this can move forward. Also found two correctness issues in the current diff: in `superset/commands/chart/export.py`, the circular-reference guard (`_seen`) doesn't survive across the nested `ExportChartsCommand(...).run()` calls used for referenced charts/annotation layers — each nested call gets a fresh `_seen=None`, so two charts pointing at each other's annotations will recurse forever. And in both `superset/commands/chart/importers/v1/__init__.py` and `superset/commands/dashboard/importers/v1/__init__.py`, `import_annotation_layer(config, overwrite=False)` is hardcoded, so `overwrite=True` never actually updates annotation layers on reimport. There's also a pile of still-open review threads from codeant/bito flagging things like the mutable-default schema list and dropped legacy integer annotation values — worth a pass to see which are real before the next round. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
