rusackas commented on PR #40635: URL: https://github.com/apache/superset/pull/40635#issuecomment-5099446794
@ytihianine one more thing before this can land. `messages.po` has duplicate msgid entries now, the four new dataset soft-delete-restore strings and `Copy query` each show up twice, probably a leftover from one of the `master` merges. A rebase might fix much of it. For the dataset-restore ones it's not just cosmetic, though. `msgfmt` keeps the earlier blank confirmed copy over the later fuzzy one with your actual French text, so those four silently fall back to English at compile time. Lastly the `% of parent`/`% of total` entries from my last note are still confirmed and still fail to compile. Want me to take a pass at cleaning any of this up, or would you want to run another `pybabel update` to see if that sorts it out on your end? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
