rusackas commented on PR #35867: URL: https://github.com/apache/superset/pull/35867#issuecomment-5099474184
Turns out #41637 already shipped this exact fix in July (splice/arrayMove reorder, committing through `onChange`/`handleChange` instead of the stale `onDropLabel` closure) across `DndMetricSelect`, `DndFilterSelect`, `AdhocFilterControl`, and `OptionSelector`. That's why this keeps drifting into conflicts, it's duplicating code that's already on `master`. I've been driving this branch, so I'll close it out rather than continue to ask for a rebase on something already fixed. Thanks for tracking down the original swap-vs-splice bug, @CoderSxy, it pointed straight at the real root cause. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
