rusackas commented on PR #39946: URL: https://github.com/apache/superset/pull/39946#issuecomment-5099477043
Thanks for reworking this into `request_loader()`, that's the right spot for it. But `test-mysql`/`test-postgres`/`test-sqlite` are failing on your own new tests, not something unrelated. `test_get_dataset_list_with_jwt_auth` passes `owners=` to `insert_dataset()`, which doesn't take that kwarg (tests/integration_tests/datasets/api_tests.py). And both invalid-token tests assert a 401 but flask-jwt-extended is actually returning 422 for a malformed token, so either the assertion or the handling in `request_loader()` needs to change. Can you fix those up and get CI green? Also worth resolving Bito's guest-token-fallback thread while you're in there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
