rusackas commented on PR #41536:
URL: https://github.com/apache/superset/pull/41536#issuecomment-5099480361
Sorry, I steered you wrong on the lodash import. I went and checked,
`master`'s `Chart.tsx` already uses `lodash-es` for `debounce` since #41511's
tree-shaking migration merged back in June, so your original import was
actually right and matched the rest of the codebase. Mind flipping `import
debounce from 'lodash/debounce'` back to `import { debounce } from
'lodash-es'`?
Everything else here, the `ResizeObserver` remeasure and the new tests,
looks good to me. Thanks for the help with all this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
