younsl commented on code in PR #240:
URL:
https://github.com/apache/superset-kubernetes-operator/pull/240#discussion_r3662547338
##########
charts/superset-operator/values.schema.json:
##########
@@ -22,6 +22,18 @@
}
}
},
+ "imagePullSecrets": {
+ "description": "References to Secrets in the release namespace used to
pull the operator image from a private registry. See
https://pkg.go.dev/k8s.io/api/core/v1#LocalObjectReference";,
+ "type": "array",
+ "items": {
+ "type": "object",
+ "additionalProperties": false,
+ "properties": {
+ "name": { "type": "string" }
Review Comment:
Good catch — added `"minLength": 1` in 00a5ee7 so an empty `name` fails
schema validation instead of rendering a useless `imagePullSecrets` entry.
Verified with `helm lint` and `helm unittest` (3 suites, 9 tests, 25 snapshots
passing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
