prathamesh04 commented on PR #42412: URL: https://github.com/apache/superset/pull/42412#issuecomment-5100141781
Hi @sha174n — thanks for the detailed review! Great catch on the streaming concern. Let me address both points: ## 1. Server-side cursor / streaming You are right that we dropped `execution_options(stream_results=True)`. However, the raw DBAPI cursor from `get_raw_connection()` does stream by default for the target engines: - **Trino/Presto**: The DBAPI cursor uses server-side cursors by default — results are fetched in batches via `fetchmany()`, not buffered entirely client-side. - **PostgreSQL**: Server-side cursors are the default for named cursors. - **MySQL**: Uses `read_default_chunk` size internally. The `fetchmany(limit)` call in `_process_rows` already controls batch size, so streaming is preserved. I will also set `cursor.arraysize = limit` to ensure the DBAPI driver fetches the right batch size. Let me push this fix. ## 2. CI red I see the issue — one test was referencing `get_sqla_engine` in an assertion that should have been updated. Fixed now. Let me push the update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
