rusackas opened a new pull request, #42503:
URL: https://github.com/apache/superset/pull/42503

   ### SUMMARY
   Right now a red check on Python-Unit just means scrolling raw pytest logs to 
find which test broke. This wires up EnricoMi/publish-unit-test-result-action 
so failing tests get annotated inline on the PR diff instead.
   
   pytest already writes JUnit XML for free via `--junit-xml`, so I added that 
to all three pytest invocations in the `unit-tests` job (the main suite and the 
two 100%-coverage sub-suites) and upload the results as an artifact, even on 
failure since that's exactly when it matters. A second workflow publishes the 
check run, triggered via `workflow_run` so it always runs in the base-branch 
context and can safely hold `checks:write` even for fork or Dependabot PRs, 
without ever checking out PR code. Same pattern this repo already uses for the 
translation-regression bot.
   
   Scoped to Python-Unit only for now. Jest's 8-way shard and the Python 
integration matrix (3 DBs + presto/hive) seem like natural follow-ups once this 
pattern proves out, figured it's better to land something small first.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A, CI-only change.
   
   ### TESTING INSTRUCTIONS
   `zizmor` and `pre-commit` both pass clean on the changed/new workflow files.
   
   One thing worth flagging: the second workflow won't actually fire on this PR 
itself. `workflow_run` only triggers once both files are on `master`, so the 
check run won't show up until after merge, same deal as the existing 
translation-regression-comment workflow. Once merged, any PR touching Python 
code should get a "Python Unit Test Results" check with per-test annotations on 
failure.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to