rusackas opened a new pull request, #42506:
URL: https://github.com/apache/superset/pull/42506

   ### SUMMARY
   `helm/chart-releaser-action` is now allowlisted upstream by ASF Infra 
(`apache/infrastructure-actions/actions.yml`) at v1.7.0 
(`cae68fefc6b5f367a0275617c9f83181ba54714f`), so the git-submodule fork under 
`.github/actions/chart-releaser-action` — added as a workaround back when it 
wasn't allowlisted — is no longer needed.
   
   Also drops a now-dead debug step in `superset-helm-release.yml` that just 
`cat`'d the vendored action's `action.yml`.
   
   **`helm/chart-testing-action` intentionally NOT included here.** It's also 
allowlisted (v2.8.0, `6ec842c01de15ebb84c8627d2744a0c2f2755c9f`), but that 
release depends internally on `astral-sh/[email protected]`, which isn't itself 
on the allowlist (only v8.1.0+ currently are). Confirmed this directly rather 
than assuming — see TESTING INSTRUCTIONS. De-vendoring it needs an ASF Infra 
request to add that specific `setup-uv` SHA (or for `chart-testing-action` to 
cut a release pinning a currently-allowlisted `setup-uv` version) first. Left 
it on the vendored submodule with a comment explaining why.
   
   Also skipping `helm/kind-action` per discussion — installing/testing the 
chart in CI via `kind` is a separate, larger change than de-vendoring, and not 
something we're pursuing right now.
   
   ### TESTING INSTRUCTIONS
   Validated directly against real CI on this branch before opening:
   - `helm/chart-releaser-action@cae68fefc6b5f367a0275617c9f83181ba54714f` 
(v1.7.0): ran successfully in an isolated diagnostic job (`install_only: true`, 
no release/publish side effects) — 
https://github.com/apache/superset/actions/runs/30331312381 (job 
`diagnostic-chart-releaser-allowlist`).
   - `helm/chart-testing-action@6ec842c01de15ebb84c8627d2744a0c2f2755c9f` 
(v2.8.0): failed at `Set up job` — 
https://github.com/apache/superset/actions/runs/30331090959 — annotation 
confirms `astral-sh/setup-uv@eb1897b8dc4b5d5bfe39a428a8f2304605e0983c` (v7.0.0) 
is not allowlisted. This is why it's staying vendored for now.
   - The actual `superset-helm-release.yml` release job itself was **not** run 
end-to-end (it force-pushes branches and opens a real PR to `gh-pages` — too 
disruptive to trigger just for validation); the `chart-releaser-action` swap is 
validated via the isolated `install_only` job instead, which exercises the same 
allowlist gate without the side effects.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to