rusackas commented on PR #42511: URL: https://github.com/apache/superset/pull/42511#issuecomment-5107333933
Pushed two follow-up commits addressing review feedback: **1. Nightly baseline instead of every push to master.** Persisting a new baseline on every push (many times a day) would burn a full production build each time for no benefit a once-daily refresh doesn't already cover. Moved baseline persistence to a new `frontend-bundle-size-nightly.yml`; `superset-frontend.yml`'s `bundle-size` job is now `pull_request`-only (compare + alert against the last nightly baseline, never persist). Also added `actions/cache` for webpack's persistent filesystem build cache across CI runs -- without it, every PR would've paid the full cold-build cost (several minutes) instead of the ~20s warm-build cost the cache is supposed to buy, since GH-hosted runners don't carry disk state between jobs. **2. Nightly bundle-analyzer report + visibility badges.** `BUNDLE_ANALYZER=true npm run build` rides along in the same nightly build (independent env-gated addition in `webpack.config.js`, no extra build needed) and now publishes the treemap to Netlify -- the same host already trusted here for Storybook (`superset-storybook.netlify.app`) and docs previews, reusing the existing `NETLIFY_AUTH_TOKEN` secret. Also added README badges for both Storybook (which turns out has been live and current the whole time, just not linked from anywhere) and the new analyzer report. Does *not* publish the sibling `statistics.html` sunburst chart -- `webpack.config.js` documents it as routinely exceeding 100MB for this app, too large for a static site page. The Netlify publish step is gated on `NETLIFY_BUNDLE_ANALYZER_SITE_ID` and no-ops until that secret exists, so this is safe to merge now. Turning it on just needs a new (free) Netlify site named `superset-bundle-analyzer` and its site ID added as that secret -- nothing else in the workflow depends on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
