Copilot commented on code in PR #42525:
URL: https://github.com/apache/superset/pull/42525#discussion_r3667922714
##########
superset-frontend/packages/superset-ui-core/package.json:
##########
@@ -92,7 +92,7 @@
"@emotion/cache": "^11.4.0",
"@emotion/react": "^11.4.1",
"@emotion/styled": "^11.14.1",
- "@testing-library/dom": "^9.3.4",
+ "@testing-library/dom": "^10.4.1",
"@testing-library/jest-dom": "*",
Review Comment:
Using `"*"` for `@testing-library/jest-dom` makes installs non-deterministic
and can silently pull future major versions (especially risky given v7 includes
breaking changes). Consider pinning this to `^7.0.0` (and similarly in other
workspaces) to keep dependency resolution predictable.
##########
superset-frontend/package.json:
##########
@@ -275,8 +275,8 @@
"@swc/core": "^1.15.46",
"@swc/plugin-emotion": "^14.15.0",
"@swc/plugin-transform-imports": "^12.5.0",
- "@testing-library/dom": "^9.3.4",
- "@testing-library/jest-dom": "^6.9.1",
+ "@testing-library/dom": "^10.4.1",
+ "@testing-library/jest-dom": "^7.0.0",
Review Comment:
`@testing-library/jest-dom` v7 has a breaking change requiring Node.js >=
22. If this repo’s CI/build images or local dev tooling still target an older
Node version, installs/tests will fail. Consider updating the repo’s declared
Node version (e.g., `engines`, `.nvmrc`/Volta, CI node setup) in the same PR or
adding a clear follow-up task.
##########
superset-frontend/package.json:
##########
@@ -275,8 +275,8 @@
"@swc/core": "^1.15.46",
"@swc/plugin-emotion": "^14.15.0",
"@swc/plugin-transform-imports": "^12.5.0",
- "@testing-library/dom": "^9.3.4",
- "@testing-library/jest-dom": "^6.9.1",
+ "@testing-library/dom": "^10.4.1",
+ "@testing-library/jest-dom": "^7.0.0",
Review Comment:
The PR title/description indicates only `@testing-library/jest-dom` is being
bumped, but this PR also bumps `@testing-library/dom` (and does so across
multiple workspaces). Please update the PR title and/or description to
explicitly mention the `@testing-library/dom` upgrade as part of the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
