rusackas commented on PR #42316: URL: https://github.com/apache/superset/pull/42316#issuecomment-5107793812
Nice touch fixing the export selector for standalone (`#app .chart-container` makes sense since standalone skips the `.panel-body` wrapper). Bito's and Codeant's flags (missing `export` on `UseExploreAdditionalActionsMenuOptions`, and the boolean coercion on `show_download`) look already fixed in the latest commit, worth resolving those threads. One thing before I approve, though. `useExploreAdditionalActionsMenu.test.tsx` never got updated, so the `showDataExportOnly` filtering (hiding the screenshot/PDF items for the standalone menu) has zero direct coverage. Mind adding a case for that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
