rusackas commented on PR #42411: URL: https://github.com/apache/superset/pull/42411#issuecomment-5107804586
I think Copilot's threads on the new test are false positives. `ValidationError.messages` is just the list you passed in, `field_name` doesn't restructure it into a dict, so `error.messages[0]` works fine here, not the TypeError/KeyError the bot predicts. The `% not in message` nit is fair but minor. Separately: `DatabaseExtraValidationError` doesn't look like it's actually raised anywhere. `extra_validator` in `superset/databases/schemas.py` builds its own inline message and already uses the correct `%(key)s`. Is this class dead code, or am I missing a caller? Doesn't block the fix either way, just curious. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
