bito-code-review[bot] commented on code in PR #41492:
URL: https://github.com/apache/superset/pull/41492#discussion_r3668126764
##########
superset/databases/schemas.py:
##########
@@ -1165,6 +1165,15 @@ class DatabaseSchemaAccessForFileUploadResponse(Schema):
)
+class IdentifierQuoteSchema(Schema):
+ start = fields.String(
+ metadata={"description": "Character that opens a quoted identifier"}
+ )
+ end = fields.String(
+ metadata={"description": "Character that closes a quoted identifier"}
+ )
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to add test coverage for the `identifier_quote`
field is appropriate and improves the test suite's robustness. Since you have
already addressed this by adding a dedicated test in `test_schemas.py`, no
further action is required for this specific thread.
Regarding the other review comments in this PR, there are several
suggestions from the automated reviewer concerning missing type annotations on
new class-level attributes and schema fields. These are minor issues related to
project-specific coding standards. Would you like me to help you address these
remaining type-hint suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
