rusackas commented on PR #42440: URL: https://github.com/apache/superset/pull/42440#issuecomment-5109551072
Hey @prathamesh04, thanks for the fix! CI's failing on `test_views_are_secured`, and it's not from the sqllab change, it's the second commit dropping `@has_access` from `language_pack`, which isn't mentioned in the PR description. Mind splitting that off into its own PR? An auth change like that needs to stand on its own for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
