rusackas commented on PR #41549: URL: https://github.com/apache/superset/pull/41549#issuecomment-5111101948
Indeed, the review is/was old, but still LGTM in general. Still open things that are not blockers, but I'm curious how/when you want to track or handle them (is there an overarching tracking issue, perhaps?): * the CLI commands still aren't directly unit-tested and probably ought to be * the M:N tripwire I flagged last time seems to be unsolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
