rusackas commented on PR #42463: URL: https://github.com/apache/superset/pull/42463#issuecomment-5113823153
Thanks for narrowing this after Codeant's flag, that's a good improvement over catching every `SupersetGenericDBErrorException`. One thing I'm still not sure about: `_has_jinja_markers` checks the dataset's SQL text, not what actually failed, so a genuine DB/connection error on a Jinja-templated dataset would now get silently logged as a warning too instead of surfacing to the user. Might be worth keying off the exception message (or catching closer to where `get_virtual_table_metadata` raises the template-processing error) instead of sniffing the SQL string? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
