bito-code-review[bot] commented on PR #42573: URL: https://github.com/apache/superset/pull/42573#issuecomment-5120419671
<!-- Bito Reply --> The flagged issue is correct. The `getScrollBarSize` utility now forces a measurement based on the 8px custom scrollbar width, which is then used by `TableChart.tsx` for container compensation. If the outer container does not use the same custom scrollbar, it will have a different native scrollbar width, leading to the reported layout drift. To resolve this, you should separate the concerns: keep a utility that measures the *actual* native scrollbar width (without forcing custom styles) for general use, and use a constant for the custom scrollbar width where specifically needed (e.g., in `StickyWrap`). ### Proposed Fix 1. Revert `getScrollBarSize.ts` to measure the native scrollbar width without injecting the custom style probe. 2. Continue using `CUSTOM_SCROLLBAR_SIZE` constant in `StickyWrap` for styling. Would you like me to implement these changes? I can also check the rest of the PR comments if you would like to address them as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
