ayush-sharaf commented on issue #42564: URL: https://github.com/apache/superset/issues/42564#issuecomment-5123995809
Thanks @rusackas — @eschutho, happy to sync on this whenever convenient. More broadly: I'd like to help out on improving action logging in general, not just this one event. While building an audit trail over the `logs` table for embedded dashboards I've been running into the same class of gap repeatedly — events that fire but carry no payload, or carry just enough to know *something* happened without knowing *what*. #42562 (Drill to Detail emitting no event at all) and this issue are two instances; I suspect there are more once the user-event surface is enumerated. Things I'm offering to take on, in whatever order maintainers prefer: - **Audit the existing user events** — walk every `LOG_ACTIONS_*` dispatch site and document what each actually emits today vs. what a downstream consumer would need. Useful as a shared reference before deciding on individual fixes. - **This issue** — approach A (enrich at the `handleApply` dispatch site) and/or B (allowlisted enrichment in `loggerMiddleware`), whichever shape you'd prefer. - **Convention for payloads** — if there's an agreed shape for identifying dashboard/chart/filter context, new events would be more consistent and existing ones easier to normalize. - **The privacy question** — I flagged in the issue that filter values are user data. I'm happy to implement whatever the project's preference is here (names + set/unset by default, values behind an explicit config flag, or something else), but I'd rather have that decision made by maintainers than pick one myself. I don't want to run ahead of a design decision, so I'll hold off on a PR until there's a preference on the payload shape and on value capture. If it's easier to discuss in a Slack thread or on the dev list instead, point me at it and I'll move there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
