Copilot commented on code in PR #42209:
URL: https://github.com/apache/superset/pull/42209#discussion_r3679056302
##########
.github/workflows/superset-helm-release.yml:
##########
@@ -113,15 +127,72 @@ jobs:
throw new Error("Branch name is not defined.");
}
- const pr = await github.rest.pulls.create({
+ // The branch is force-recreated from gh-pages on every run, so an
+ // already-open PR for it now reflects this run's charts; opening
+ // another would both fail (422) and recreate the stale-PR pileup
+ // this fixed branch exists to avoid.
+ const { data: existing } = await github.rest.pulls.list({
+ owner,
+ repo,
+ state: "open",
+ head: `${owner}:${branchName}`,
+ base: "gh-pages",
+ });
+
+ let current;
+ if (existing.length > 0) {
+ current = existing[0];
+ core.info(`Reusing existing pull request: ${current.html_url}`);
+ } else {
+ const { data: pr } = await github.rest.pulls.create({
+ owner,
+ repo,
+ title: "Helm chart release",
+ head: branchName,
+ base: "gh-pages", // Adjust if the target branch is different
+ body: [
+ "This PR releases Helm charts to the gh-pages branch.",
+ "",
+ "It is force-updated from the tip of `gh-pages` by every
release run,",
+ "so it always contains every chart released since the last
merge and",
+ "never needs to be closed as superseded.",
+ ].join("\n"),
+ });
+ current = pr;
+ core.info(`Pull request created: ${current.html_url}`);
+ }
+
+ // Sweep release PRs left open by older runs (per-SHA
helm-publish-*
+ // branches from the previous scheme). Their content is a subset of
+ // the evergreen PR, so close them with a pointer to it.
+ const { data: openPrs } = await github.rest.pulls.list({
owner,
repo,
- title: `Helm chart release for ${branchName}`,
- head: branchName,
- base: "gh-pages", // Adjust if the target branch is different
- body: `This PR releases Helm charts to the gh-pages branch.`,
+ state: "open",
+ base: "gh-pages",
+ per_page: 100,
});
- core.info(`Pull request created: ${pr.data.html_url}`);
+ for (const stale of openPrs) {
+ if (
+ stale.number !== current.number &&
+ stale.head.repo?.full_name === process.env.GITHUB_REPOSITORY &&
+ stale.head.ref.startsWith("helm-publish")
+ ) {
Review Comment:
The stale-PR sweep closes any open PR whose head ref starts with
"helm-publish". That matches not only the old per-SHA branches
(helm-publish-<sha>) but also any other branch a maintainer might happen to
name with that prefix (e.g. helm-publish-fix), which could be closed
unintentionally. Since the intent is to close only the old per-SHA branches,
the match should be narrowed to `${branchName}-`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
