prathamesh04 commented on PR #42339: URL: https://github.com/apache/superset/pull/42339#issuecomment-5125900913
Hi @rusackas — I've addressed both points: 1. **`run()` now uses `model_ids`**: Calls `self.validate()` to validate the tag IDs exist via `TagDAO.find_by_ids()`, then iterates the validated tags' `objects` to collect associated dashboard/chart IDs. These are passed to `_file_content()` together with any explicitly provided `dashboard_ids`/`chart_ids`. 2. **Removed dead `export()` staticmethod**: Deleted since `run()` provides the same functionality and nothing calls `export()` anymore. Ready for re-review. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
