rusackas commented on PR #42529:
URL: https://github.com/apache/superset/pull/42529#issuecomment-5127240080
Couple of things before this is mergeable. `sharded-jest-tests (4)` is red
on this commit: the new `test.each` in Menu.test.tsx doesn't hover `Sources`
before asserting on `Datasets`, but Datasets only renders once that submenu is
expanded, same as the existing test right above it does.
Also, codeant's thread on Menu.tsx:247 is still open and valid,
`path.startsWith('/dataset')` would also match something like `/datasetXyz`,
worth tightening to match `/dataset/` (or the exact `/dataset`) instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
