rusackas commented on PR #42284: URL: https://github.com/apache/superset/pull/42284#issuecomment-5127276871
Nice unblock for legacy charts, this is a thorough writeup of the failure mode. My one worry is that `build_query_context_from_form_data` reimplements a good chunk of each viz plugin's `buildQuery` in Python, so it'll quietly drift as the frontend logic evolves. Is there a tripwire (test or comment) tying the two together, or do we just accept periodic drift here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
