codeant-ai-for-open-source[bot] commented on code in PR #42481:
URL: https://github.com/apache/superset/pull/42481#discussion_r3681706400
##########
superset-frontend/src/features/alerts/components/AlertStatusIcon.tsx:
##########
@@ -92,6 +94,13 @@ export default function AlertStatusIcon({
lastStateConfig.label = t('Alert Triggered, In Grace Period');
lastStateConfig.status = AlertState.Grace;
break;
+ case AlertState.Retrying:
+ lastStateConfig.icon = Icons.Running;
+ lastStateConfig.label = isReportEnabled
+ ? t('Report retrying')
+ : t('Alert retrying');
+ lastStateConfig.status = AlertState.Retrying;
+ break;
Review Comment:
**Suggestion:** The new retrying state uses the running icon, but
`isRunningIcon` only checks for `AlertState.Working`, so retrying icons are
rendered at the normal size instead of receiving the enlarged running-state
styling. Include `AlertState.Retrying` in the running-icon condition so the new
state is visually consistent with active execution. [css layout issue]
<details>
<summary><b>Severity Level:</b> Minor ๐งน</summary>
```mdx
- โ ๏ธ Retrying alerts display an inconsistently sized active-state icon.
- โ ๏ธ Alerts and reports retry status loses visual emphasis.
- โ ๏ธ Execution log and report list presentation differ from working-state
styling.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=bd8c568aa0ea4932b8f72498140f0194&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=bd8c568aa0ea4932b8f72498140f0194&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/features/alerts/components/AlertStatusIcon.tsx
**Line:** 97:103
**Comment:**
*Css Layout Issue: The new retrying state uses the running icon, but
`isRunningIcon` only checks for `AlertState.Working`, so retrying icons are
rendered at the normal size instead of receiving the enlarged running-state
styling. Include `AlertState.Retrying` in the running-icon condition so the new
state is visually consistent with active execution.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42481&comment_hash=9885c2b49c420a1ee098a7cd655f19b27f962d7ac3a829407ec606109bee8644&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42481&comment_hash=9885c2b49c420a1ee098a7cd655f19b27f962d7ac3a829407ec606109bee8644&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
